Re: [webrtc-pc] Complete ice server url validation (#2996)

> ... reusing the application/x-www-form-urlencoded parser means making ?&transport=udp parsable

Less custom URL parsing seems in line with being _"consistent with how we treat URLs elsewhere in the platform."_. https://github.com/w3c/webrtc-pc/issues/2660#issuecomment-1494140703

> an alternative would be to instead do the split on `=` ourselves (rather than invoking the URL algorithm), limiting the set of acceptable query strings to `?transport=udp` and `?transport=tcp`

OTOH, if this simple string compare lets us keep this in REC, why not do that for now, and add application/x-www-form-urlencoded back in later?

That seems a reasonable way to increment here to me.

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/2996#issuecomment-2327010334 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Tuesday, 3 September 2024 16:56:53 UTC