- From: Harald Alvestrand via GitHub <sysbot+gh@w3.org>
- Date: Thu, 22 Feb 2024 11:14:03 +0000
- To: public-webrtc-logs@w3.org
Since we're now declaring that codec definitions (and their enabled status) are per-sender/receiver properties, I think #1 is the best approach. I do think that RTCRtpSender.SetParameters(encodings.codec = new codec) may be an obvious enough surface that we don't need to have RTCRtpSender.AddCodec() - if you're not going to send it, why are you bothering to enable it? Similarly, RTCRtpReceiver.SetCodecPreferences(new codecs) should be enough API surface for the receiver - if you're not going to announce that you can receive it, why bother? In retrospect, it was probably a mistake to put SetCodecPreferences() on the transceiver. (2 is a bad idea because it goes at cross purposes with the idea of deriving codecs from installed transform. 3 is a bad idea because setCodecPreferences() isn't defined to touch the sender.) -- GitHub Notification of comment by alvestrand Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2929#issuecomment-1959227640 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Thursday, 22 February 2024 11:14:05 UTC