Re: [webrtc-pc] receiver.getParameters().codecs is broken (regression) (#2956)

@alvestrand what are next steps? Do we back out https://github.com/w3c/webrtc-pc/pull/2935 for now, or do you have a PR in the hopper?

From https://github.com/w3c/webrtc-pc/issues/2925#issue-2078387100:
> Suggested revised model
>
> ... When calling setCodecPreferences, checking is done against receiver.[[codecs]], not against sender/receiver.getCapabilities(). If setCodecPreferences() includes a codec with the “enabled” flag set to false in the receiver’s [[codecs]] slot, it is set to “true”.

We probably need new internal slots for this instead, e.g. transceiver.[[SendCodecCapabilities]] and [[ReceiveCodecCapabilities]] (defaulting to the implementation list), as appropriating [[SendCodecs]] or [[ReceiveCodecs]] for this (defaulting to empty) seems to interfere with their existing purpose of reflecting what's been negotiated (#2967).



-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2956#issuecomment-2080031280 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Friday, 26 April 2024 19:50:36 UTC