Re: [webrtc-pc] setCodecPreferences should trigger negotiationneeded (#2964)

It's a stretch of the imagination, but one can imagine a setup like this (equivalent to your "breakage of intent" setup):

- Negotiate an initial connection (DC only, for instance)
- set up a negotiationneeded handler that does an immediate O/A
- start preparing for the "real" negotiation
- - call SetCodecPreferences
- - ask for camera/microphone permission
- - add tracks when permission is given
- based on the onnegotiationneeded from addTracks, negotiate the final config based on the negotiationneeded in "add tracks"

The change will then cause an extra negotiation without the media tracks, which may or may not have any bad effects.
The fix would be "move the handler setup to just before the addTrack". But it is a change in behavior.


-- 
GitHub Notification of comment by alvestrand
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2964#issuecomment-2076452317 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Thursday, 25 April 2024 06:20:10 UTC