- From: Tove Petersson via GitHub <sysbot+gh@w3.org>
- Date: Wed, 17 Apr 2024 09:00:36 +0000
- To: public-webrtc-logs@w3.org
Having to manually stop tracks is just the type of gotchas that I think we should strive hard to avoid when possible. It’s way too easy for a developer to miss, leading to lingering privacy indicators disconcerting users.
In this case the cost to fix the issue is also next to zero for applications that do not need to use both the injection and switch-track model. (I expect this to be the vast majority of applications.)
Compare:
```
controller.onnewsource = ({stream}) => {
video.srcObject = stream;
};
await getDisplayMedia({controller, surfaceSwitchingMethods: [“replace”], ...});
```
to
```
controller.onnewsource = ({stream}) => {
video.srcObject = stream;
};
const sessionStream = await getDisplayMedia({controller, someOtherOptIn: “include”, ...});
sessionStream.getTracks().forEach(track => track.stop());
```
The former is both less code and less error-prone than the latter.
--
GitHub Notification of comment by tovepet
Please view or discuss this issue at https://github.com/w3c/mediacapture-screen-share-extensions/issues/4#issuecomment-2060757646 using your GitHub account
--
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 17 April 2024 09:00:38 UTC