- From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
- Date: Thu, 09 Mar 2023 17:06:48 +0000
- To: public-webrtc-logs@w3.org
Hi @dontcallmedom, I noticed you added amendments to this PR. Thanks for doing that! I see you also removed the `Editorial` label. I just had a question about which part(s) are not considered editorial? In my view, this PR mostly changes the formatting of four internal variables to be consistent with the others. Before: <img width="729" alt="image" src="https://user-images.githubusercontent.com/3136226/224083647-116f2a15-1fbe-48d0-95e0-eca121f7bf47.png"> After: <img width="743" alt="image" src="https://user-images.githubusercontent.com/3136226/224084367-801a8bea-effb-417b-87ad-eb827914c788.png"> These were already main-thread variables set by algorithms, e.g. before: <img width="366" alt="image" src="https://user-images.githubusercontent.com/3136226/224090997-54d631ca-6245-4d10-a62f-a5527c44eb4e.png"> and after: <img width="399" alt="image" src="https://user-images.githubusercontent.com/3136226/224091086-ac9803c2-654f-4ccf-8a24-6845548ce881.png"> I.e. they already acted as internal slots. IOW, this PR isn't solving any race which internal slots are sometimes introduced to solve. So does it need amendments? The PR also fixes [this typo](https://w3c.github.io/webrtc-pc/#dom-rtcicetransport-ongatheringstatechange) (a [RTCIceTransport](https://w3c.github.io/webrtc-pc/#dom-rtcicetransport) doesn't have an [ICE gathering state](https://w3c.github.io/webrtc-pc/#dfn-ice-gathering-state)): <img width="769" alt="image" src="https://user-images.githubusercontent.com/3136226/224097932-6f232616-0edf-4a7f-9058-27eaa967c585.png"> ...but this prose is not just wrong but normatively redundant since the actual algorithm that fires the event is correct. — we could break that out into a separate PR, since I just noticed the prose on the handlers above and below are also redundant, and [one of them](https://w3c.github.io/webrtc-pc/#dom-rtcicetransport-onstatechange) also wrong (refers to the WebIDL [state](https://w3c.github.io/webrtc-pc/#dom-icetransport-state) as the trigger of the event). Since we'll be working with the amendments process for the foreseeable future, I wanted to understand whether editorial changes of REC are: 1. discouraged? 2. require tracking as amendments? E.g. do readers care about editorial differences? I can see advantages either way. Sorry for the long message, but editing on REC documents is new and it's not always clear what's expeced. -- GitHub Notification of comment by jan-ivar Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/2826#issuecomment-1462431989 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Thursday, 9 March 2023 17:06:50 UTC