Re: [webrtc-pc] Inconsistent initialization of scaleResolutionDownBy (#2730)

I got this comment out-of-band:
> have you considered changing scaleResolutionDownBy to a field that is ignored for audio (instead of being an error)? That would mean you 1) could set a default in WebIDL, and 2) wouldn't need to come up with an error for passing it to audio.

This seems reasonable to me, as dictionaries are generally only examined for expected inputs. We'd have to not just ignore it but remove it, or it'd show up in getParameters() which would be undesirable, but I think this is a winner. Updating PR.

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2730#issuecomment-1258710672 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 26 September 2022 22:29:04 UTC