Re: [webrtc-encoded-transform] Make RTCRtpSender.generateKeyFrame take a single optional rid parameter. (#146)

The reason behind individual rid calling is that the promise resolution is then unambiguous and can provide the timestamp, which was thought useful for transforms.
For sender, there is no such need but it seems good to align both generateKeyFrame methods.

That said, I can understand the desire to support the 'generateKeyFrame' for all rids.
I do not see much interest  interest in generateKeyFrame for more than one but not all rids.
How about the following for both sender and transformer methods:
- generateKeyFrame takes an optional rid parameter.
- If no rid parameter is sent, generate a key frame for all rids, but resolve the promise based on the first negotiated rid.

-- 
GitHub Notification of comment by youennf
Please view or discuss this issue at https://github.com/w3c/webrtc-encoded-transform/pull/146#issuecomment-1237769869 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Tuesday, 6 September 2022 07:35:30 UTC