W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > October 2022

Re: [webrtc-pc] TypeError unless all or none of encodings have rids (#2774)

From: Dominique Hazael-Massieux via GitHub <sysbot+gh@w3.org>
Date: Thu, 13 Oct 2022 08:26:34 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-1277232255-1665649591-sysbot+gh@w3.org>
thanks @jan-ivar for integrating the changes in amendments.json - indeed, the CI error is a recent addition to make sure we don't lose track of this.
FWIW, I had to tweak [a bit the change you made](https://github.com/w3c/webrtc-pc/commit/7666450321f7da266fa3a05e959869e906261ccf), since the id referenced in amendments.json needs to be for an element that contains the changes (you had picked the `<dt>` when the changes were in the `<dd>`); I'll try to see how to make it easier to review these amendment descriptions.

GitHub Notification of comment by dontcallmedom
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/2774#issuecomment-1277232255 using your GitHub account

Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Thursday, 13 October 2022 08:26:35 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:59 UTC