W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > October 2022

Re: [mediacapture-screen-share] Address nullability of DisplayMediaStreamOptions.controller (#236)

From: youennf via GitHub <sysbot+gh@w3.org>
Date: Mon, 03 Oct 2022 08:47:22 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-1265126103-1664786840-sysbot+gh@w3.org>
An example of where it makes some sense to use an optional nullable dictionary member is RequestInit.body (https://fetch.spec.whatwg.org/#requestinit). Request has a nullable body getter (https://fetch.spec.whatwg.org/#dom-body-body) and it might be handy to use this getter when creating a new Request from an existing one.

In our particular case, there is no corresponding controller getter so keeping it as a simple optional member seems good.

GitHub Notification of comment by youennf
Please view or discuss this issue at https://github.com/w3c/mediacapture-screen-share/issues/236#issuecomment-1265126103 using your GitHub account

Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Monday, 3 October 2022 08:47:24 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:59 UTC