W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > May 2022

[webrtc-pc] Improve WPT testing of setParameters (#2729)

From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
Date: Fri, 06 May 2022 22:37:42 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issues.opened-1228436826-1651876661-sysbot+gh@w3.org>
jan-ivar has just created a new issue for https://github.com/w3c/webrtc-pc:

== Improve WPT testing of setParameters ==
[Create an RTCRtpSender](https://w3c.github.io/webrtc-pc/#dfn-create-an-rtcrtpsender) says: _"If sendEncodings is given as input to this algorithm, and is non-empty, set the [[[SendEncodings]]](https://w3c.github.io/webrtc-pc/#dfn-sendencodings) slot to sendEncodings. Otherwise, set it to a list containing a single [RTCRtpEncodingParameters](https://w3c.github.io/webrtc-pc/#dom-rtcrtpencodingparameters) with [active](https://w3c.github.io/webrtc-pc/#dom-rtcrtpencodingparameters-active) set to true."_

This says [[SendEncodings]] is never empty, but browsers [are returning](https://jsfiddle.net/jib1/e19zur8k/) `[]` from `sender.getParameters().encodings`.

Relevant [WPT tests are green](https://wpt.fyi/results/webrtc/RTCRtpParameters-encodings.html?label=experimental&label=master&aligned) because they [only check after negotiation](https://github.com/web-platform-tests/wpt/blob/master/webrtc/RTCRtpParameters-encodings.html#L78).

Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2729 using your GitHub account

Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Friday, 6 May 2022 22:37:47 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:57 UTC