- From: Elad Alon via GitHub <sysbot+gh@w3.org>
- Date: Fri, 10 Jun 2022 16:20:11 +0000
- To: public-webrtc-logs@w3.org
> Creating a {} crop target should not fail, because it would be premature to allocate cropping resources at this point
Regardless of whether anything is allocated, it is usually good to fail earlier rather than later, and for the failure to happen close to where things went off-track. Failing in `cropTo()` means failing in a different document, maybe even another tab one day [*]. When the failure is really associated with `cropTo()`, that's all well and good. But for failures of the type described in bulletpoint 2 of [this message](https://github.com/w3c/mediacapture-region/issues/48#issuecomment-1136330532), there is no real association with cropTo(), and that allows failing earlier.
--
[*] See #63.
--
GitHub Notification of comment by eladalon1983
Please view or discuss this issue at https://github.com/w3c/mediacapture-region/issues/48#issuecomment-1152529136 using your GitHub account
--
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Friday, 10 June 2022 16:20:13 UTC