[mediacapture-region] cropTo is returning promises but it is unclear when promises are supposed to be rejected synchronously or not (#14)

youennf has just created a new issue for https://github.com/w3c/mediacapture-region:

== cropTo is returning promises but it is unclear when promises are supposed to be rejected synchronously or not ==
For promise-based operations, we usually use language like:
1. check if state1 is ok, if not return a rejected promise // synchronously rejected promise.
2. check if state2 is ok, if not return a rejected promise // synchronously rejected promise.
3. Create a promise
4. Run the following steps in parallel: //asynchronously settled promise.
5. return promise.

It seems like the self-capture track check step can be made synchronously.
It seems the MUST validate cropTarget step should be done asynchronously, as part of a 'run steps in parallel' section.

Also the current algorithm seems to check for valid crop target twice (step 2 and step 4.2). Probably step 4.2 valid CropTarget is unneeded? Or could it be that a crop target is valid in step 2 but invalid in step 4.2.

Please view or discuss this issue at https://github.com/w3c/mediacapture-region/issues/14 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Thursday, 27 January 2022 13:02:58 UTC