Re: [webrtc-pc] scaleResolutionDownBy's odd-resolution requirement trips up HW encoders (#2802)

Hmm, should we decrease the resolution instead? cc @Pehrsons 

Encoders may vary across devices, so predictable and consistent behavior across devices seems desirable. Which way provides it?

My initial thought was to guarantee JS a minimum resolution, thinking this would at least give JS the amount of pixels it asked for. I figured JS could use layout or cropping to remove excess pixels to achieve behavior parity* across devices. Seems to work well for cameras at least.

But unless the user agent left a black border in the alignment area (centering video scaled to pre-alignment dimensions), then the image will be marginally bigger, and JS doing such cropping would be chipping away (or obscuring) actual data. This may not be evident with a camera, but with a screen-sharing presentation it might cause loss of visible borders for instance (downscaling may cause this anyway, but this may exacerbate the effect perhaps?)

Would providing a maximum (smaller) resolution instead be better? If so, we'd need to address what happens if realignment drops one dimension to 0.

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2802#issuecomment-1350176556 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Wednesday, 14 December 2022 00:34:41 UTC