W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > December 2022

Re: [webrtc-pc] Unimplementable input validation steps in setCodecPreferences (#2805)

From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
Date: Tue, 06 Dec 2022 01:03:12 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-1338509873-1670288591-sysbot+gh@w3.org>
I understand the intent, but unfortunately that's not what it says. As written, it says to throw InvalidModificationError on all input, because a dictionary A being "in" an array of dictionaries, means the array contains a reference to A, which can never happen given how the array was constructed in this case (from fresh dictionaries that at best include a copy of A).

GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2805#issuecomment-1338509873 using your GitHub account

Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Tuesday, 6 December 2022 01:03:14 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:59 UTC