Re: [webrtc-stats] Unclear pliCount, firCount, and nackCount for outbound-rtp (#658)

Nice catch!
For PLI and FIR this is simply the count of the RTCP packets with the types defined in those sections.

For NACK it is a bit more complicated since a NACK packet can contain but a base sequence number as well as at least one bitmask describing 16 additional sequence numbers relative to the base one.
[this in libwebrtc](https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/rtp_rtcp/include/rtcp_statistics.h;l=53;drc=91e23cd891fa63eca6d32c16a30a977a87c9f587;bpv=1;bpt=1) describes it as number of NACK packets but digging a bit further shows this is [nacking for each lost packet](https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/rtp_rtcp/source/rtcp_nack_stats.cc;l=26;drc=91e23cd891fa63eca6d32c16a30a977a87c9f587;bpv=1;bpt=1).

-- 
GitHub Notification of comment by fippo
Please view or discuss this issue at https://github.com/w3c/webrtc-stats/issues/658#issuecomment-1222557785 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 22 August 2022 15:58:18 UTC