Re: [webrtc-pc] Modifications to [[SendEncodings]] from setParameters and sRD can be racy (#2737)

My sense is there are two aspects to this problem:
1. The setParameters algorithm's approach of updating entire dictionaries instead of individual members overwrites unrelated data at times
2. The inherent race of two sides competing to modify the `scaleResolutionDownBy` property

1 seems more problematic to me than 2.

IOW, if setParameters were a three-way merge (soving 1) then the only remaining problem would seem to be 2 which seems fine since it's an inherent race between parties (a few milliseconds earlier and you'd get one outcome, vs. a few milliseconds later and you'd get the other).

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2737#issuecomment-1216084974 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Tuesday, 16 August 2022 02:54:10 UTC