- From: henbos via GitHub <sysbot+gh@w3.org>
- Date: Tue, 02 Aug 2022 07:43:25 +0000
- To: public-webrtc-logs@w3.org
I think it got implemented in 2019 [here](https://webrtc-review.googlesource.com/c/src/+/137200) and that it worked, but when implementing simulcast in 2020 [here](https://webrtc-review.googlesource.com/c/src/+/174480) and total_encoded_bytes_target was supposedly moved from "per sender" VideoSendStream::Stats to "per layer" VideoSendStream::StreamStats it wasn't actually moved, just added and never touched. So we continued to set the value on the "per sender" stat but we began reading from the never-set "per layer" stat. The dangers of not using absl::optional<>. I suggest filing a crbug since this may be easy to fix. -- GitHub Notification of comment by henbos Please view or discuss this issue at https://github.com/w3c/webrtc-stats/issues/653#issuecomment-1202134324 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Tuesday, 2 August 2022 07:43:27 UTC