W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > March 2021

Re: [webrtc-insertable-streams] Should we rename SFrameTransform and RTCRtpScriptTransform (#65)

From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
Date: Sun, 07 Mar 2021 22:29:14 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-792365306-1615156153-sysbot+gh@w3.org>
Firstly, the streams spec is [particular](https://github.com/w3c/webtransport/issues/210#issuecomment-785175824) about what can be called "streams", so we should use "stream" when it fits.

Secondly, [transform streams](https://streams.spec.whatwg.org/#transform-stream) in the platform seem come in pairs:
TextEncoderStream includes GenericTransformStream;
TextDecoderStream includes GenericTransformStream;

CompressionStream includes GenericTransformStream;
DecompressionStream includes GenericTransformStream;
To follow that would mean changing [from](https://w3c.github.io/webrtc-insertable-streams/#sframe):
SFrameTransform includes GenericTransformStream;
SFrameEncrypterStream includes GenericTransformStream;
SFrameDecrypterStream includes GenericTransformStream;

This seems more ergonomic in JS. E.g. instead of 
transceiver.sender.transform = new SFrameTransform();
transceiver.receiver.transform = new SFrameTransform({role: "decrypt");
...we'd avoid the boolean arg and just have:
transceiver.sender.transform = new SFrameEncrypterStream();
transceiver.receiver.transform = new SFrameDecrypterStream();

GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-insertable-streams/issues/65#issuecomment-792365306 using your GitHub account

Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Sunday, 7 March 2021 22:29:17 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:53 UTC