W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > March 2020

Re: [webrtc-stats] Add counters for bytes sent by ICE pings (#534) (#535)

From: Jonas Oreland via GitHub <sysbot+gh@w3.org>
Date: Wed, 25 Mar 2020 14:16:30 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-603864117-1585145788-sysbot+gh@w3.org> 
first looking at send: it seems that the bytes are **not** included in bytesSent
a) sending on ping: https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/p2p/base/connection.cc;l=835;drc=34ad93361f96ad875bf350ced27e15b7aa126113?originalUrl=https:%2F%2Fcs.chromium.org%2F
b) sending of RTP:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/p2p/base/connection.cc;l=1353;drc=34ad93361f96ad875bf350ced27e15b7aa126113?originalUrl=https:%2F%2Fcs.chromium.org%2F

The send_tracker in then used to populate stats object: https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/p2p/base/connection.cc;l=1206;drc=34ad93361f96ad875bf350ced27e15b7aa126113?originalUrl=https:%2F%2Fcs.chromium.org%2F

===

This would mean that we could add them as "overhead" right ?

-- 
GitHub Notification of comment by jonasore
Please view or discuss this issue at https://github.com/w3c/webrtc-stats/pull/535#issuecomment-603864117 using your GitHub account
Received on Wednesday, 25 March 2020 14:16:32 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:50 UTC