W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > January 2020

Re: [webrtc-pc] Add note explaining addTrack/addTransceiver-created transceivers (#2445)

From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
Date: Fri, 24 Jan 2020 15:45:08 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-578184409-1579880706-sysbot+gh@w3.org>
(I tried using GitHub's new suggestion feature, but it didn't work on multi-line comments, and got unwieldy, so pardon the rude edit). My explanations from that review:

> I like the word "enough". Makes me think of quantity, a helpful metaphor here. So I'll lean on it.
>
> I'd like to highlight the two sides and the subset of transceivers that get associated here (those on one side). This may seem obvious to us, but people might otherwise assume some magic that isn't there.

> I find the word "attach" as a stand-in for "associated" confusing terminology

> We didn't use "will" in almost the same sentence above.

> Toned down one part that sounded a bit critical perhaps (I don't disagree mind you) 😉

@henbos LMKWYT

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/2445#issuecomment-578184409 using your GitHub account
Received on Friday, 24 January 2020 15:45:09 UTC

This archive was generated by hypermail 2.4.0 : Friday, 24 January 2020 15:45:11 UTC