W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > January 2020

Re: [webrtc-pc] new is not valid for SctpTransportState (#2422)

From: Dominique Hazael-Massieux via GitHub <sysbot+gh@w3.org>
Date: Wed, 08 Jan 2020 07:03:30 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-571918714-1578467009-sysbot+gh@w3.org>
As Harald said, there is only one instance calling that algorithm, and it is called with initialState set to "connecting", so there is no way that I can think of that "new" will ever be an exposed value. If so, it sounds like rather than adding an untestable/invisible state, we should remove the "initialState" parameter, and have create an RTCSctpTransport always use "connecting" as its initialState.

I imagine the reason not to do that is if we plan on re-using this interface out of PeerConnection in a later version - if so, adding "new" is probably OK, although maybe somewhat premature. @alvestrand can you comment as to why you had added the "new" state in your Chromium implementation?

GitHub Notification of comment by dontcallmedom
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2422#issuecomment-571918714 using your GitHub account
Received on Wednesday, 8 January 2020 07:04:09 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:36 UTC