- From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
- Date: Fri, 11 Dec 2020 16:25:25 +0000
- To: public-webrtc-logs@w3.org
> My guess is that if enough eyeballs have taken a hard look at the PR, then merging should be OK. Thanks @dontcallmedom and @henbos. I've looked over the PR again and I found no mistakes. * I did a full pass of the [Files changed](https://github.com/w3c/webrtc-pc/pull/2614/files) diff. * I followed all _"session description"_ links in the [preview](https://pr-preview.s3.amazonaws.com/jan-ivar/webrtc-pc/pull/2614.html). * I also did the same in the [preview diff](https://pr-preview.s3.amazonaws.com/w3c/webrtc-pc/2614/610c8da...jan-ivar:a3ade6c.html) though I found it unreliable (it trips over webidl that is unchanged by this patch) * I checked the new _"pendingDescription"_ variable added instead of referring to the description _"being rolled back"_. * I checked the three apply-rewordings to avoid the phrases _"prior to applying"_ and _"is applied"_ wrt the setting algorithms (replaced by _"prior to_ pendingDescription _being set"_ and _"is set successfully"_ to denote more accurately what is being referred to: the former refers to pending descriptions, the latter refers to being set as current description, which frankly remains vague but is thankfully non-normative). I think this is an improvement., so I'd like to get this in before the Dec 15th deadline. @alvestrand and @aboba can I get an `Editors can integrate`? -- GitHub Notification of comment by jan-ivar Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/2614#issuecomment-743291008 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Friday, 11 December 2020 16:25:27 UTC