Re: [webrtc-pc] On track removal: Should you mute an already muted track? (#2506)

> It says "is not already muted", but our SDP processing does this:
> > For each track in muteTracks, set the muted state of track to the value true.
> 
> Which references an algorithm that does not care if the track is already muted, it fires onmute regardless.

No, because where *muteTracks* is populated [says](https://w3c.github.io/webrtc-pc/#process-remote-track-removal): *"If track.muted is false, add track to muteTracks."*

As far as desirable outcome, I think we're doing the right thing. Firing `muted` on a track that's already muted seems wrong.

Now, there are other places in this spec where we call that mediacapture algorithm (RTCP BYE etc.) where it looks like we're not checking as carefully.

I've filed https://github.com/w3c/mediacapture-main/issues/676 to fix mediacapture.

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2506#issuecomment-608706151 using your GitHub account

Received on Friday, 3 April 2020 21:57:14 UTC