W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > September 2019

Re: [mediacapture-record] Add replaceStream to MediaRecorder (#186)

From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
Date: Mon, 16 Sep 2019 15:52:39 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-531839285-1568649158-sysbot+gh@w3.org>
@pehrsons If we can make those guarantees then I agree we shouldn't return a promise. Only if the asynchronous part can fail would a promise be needed. I don't think that's the case here. 

`replaceTrack` should probably throw if either track is `ended`. That would avoid the race you mention. 

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/mediacapture-record/pull/186#issuecomment-531839285 using your GitHub account
Received on Monday, 16 September 2019 15:52:40 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:28 UTC