W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > September 2019

Re: [mediacapture-record] Add replaceStream to MediaRecorder (#186)

From: guest271314 via GitHub <sysbot+gh@w3.org>
Date: Sat, 14 Sep 2019 00:58:44 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-531431868-1568422722-sysbot+gh@w3.org>

> How would they replace just the french audio?

That is in fact a consideration that suggested be included in this PR at https://github.com/w3c/mediacapture-record/issues/167#issuecomment-531060600. In brief, by providing a means to set the order the tracks. Further, by providing a means to parse media files. 

> So we'd like to propose this instead:
> `await recorder.replaceTrack(frenchAudioTrack, directorsCommentaryTrack);`

"instead" is not necessary language or intent. There is no reason that both `replaceStream()` and `replaceTrack()` cannot be specified and implemented.

> In addition, we propose to no longer stop the recorder if a stream's track-set changes, because it no longer makes sense to react to those. 

That essentially would resolve the issue and make the use case viable. 

> Instead, we'd copy the track-set in start(), and only stop on the first track ended. 

That would be an issue for interoperability re Chromium, Chrome https://github.com/w3c/mediacapture-fromelement/issues/78.

> If the tracks' isolation properties differ, replaceTrack would reject with SecurityError.

AFAIK `isolationchange` is not implement, correct? Do you mean `unmute` event?

GitHub Notification of comment by guest271314
Please view or discuss this issue at https://github.com/w3c/mediacapture-record/pull/186#issuecomment-531431868 using your GitHub account
Received on Saturday, 14 September 2019 00:58:45 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:48 UTC