W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > September 2019

Re: [webrtc-pc] Local versus remote rollback, and clarifying implicit SRD-rollbacks (#2294)

From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
Date: Wed, 11 Sep 2019 13:18:18 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-530376037-1568207897-sysbot+gh@w3.org>
There's no race that I'm aware of. It's more about conforming to JSEP to say `"rollback"` clears whichever one is set regardless of whether SLD(rollback) or SRD(rollback) is used, which seems fine to me as a solution.

This simplifies SRD's prose on implicit rollback too, since otherwise we'd have to fix that prose to somehow pass in whether "the description is set as a local" or "remote description", which caused its readability to drop a bit when I tried it (using a remote boolean).

I can add a PR.

GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2294#issuecomment-530376037 using your GitHub account
Received on Wednesday, 11 September 2019 13:18:19 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:28 UTC