W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > July 2019

[webrtc-pc] Pull Request: Infer SLD type from signalingState inside chained steps.

From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
Date: Wed, 31 Jul 2019 23:35:53 +0000
To: public-webrtc-logs@w3.org
Message-ID: <pull_request.opened-303163636-1564616151-sysbot+gh@w3.org>
jan-ivar has just submitted a new pull request for https://github.com/w3c/webrtc-pc:

== Infer SLD type from signalingState inside chained steps. ==
A fix for a mistake I made in https://github.com/w3c/webrtc-pc/pull/2234. Discovered this while implementing it.

Whenever we read `signalingState` and other negotiation state inside a negotiation methods, we must do so from inside its *chained* steps, to pick up the state at the time of execution (rather than time of invocation).

See https://github.com/w3c/webrtc-pc/issues/2208 for an example of where the two may differ.

See https://github.com/w3c/webrtc-pc/pull/2244
Received on Wednesday, 31 July 2019 23:35:54 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:26 UTC