W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > January 2019

Re: [mediacapture-record] Should a dataavailable event be dispatched in case there is no available data (#153)

From: Miguel Casas-Sanchez via GitHub <sysbot+gh@w3.org>
Date: Wed, 30 Jan 2019 22:20:15 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-459133053-1548886814-sysbot+gh@w3.org>
Apologies for the delay. I don't see an issue with having 0-sized blobs for the reason I gave before. The if-check is a hack I added while developing the Chrome code a long time ago, and somehow it has stuck around. Usually JS code will keep an array of `blobs` received on `onDataAvailable` and eventually concatenate those at a certain point in time for download; having a (number of) empty `blobs` won't make a difference.

> - Applications not using requestData will no longer need this if check

Like I said, the check is not needed :-)

Closing to simplify the issues accountancy; please shout if you disagree.

-- 
GitHub Notification of comment by yellowdoge
Please view or discuss this issue at https://github.com/w3c/mediacapture-record/issues/153#issuecomment-459133053 using your GitHub account
Received on Wednesday, 30 January 2019 22:20:17 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 4 June 2019 15:32:54 UTC