W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > January 2019

Re: [webrtc-stats] video packet counters should be moved out from RTCRTPStreamStats to appropriate dictionaries (#312)

From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
Date: Fri, 11 Jan 2019 15:36:12 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-453556583-1547220971-sysbot+gh@w3.org>
The reason I didn't move them initially is I misunderstood their descriptions—unsure what "sent by receiver" meant in the context of rtp/rtcp. From @alvestrand's https://github.com/w3c/webrtc-stats/issues/312#issuecomment-361946378 it seems:

* firCount: *"only valid for video and is sent by receiver"* -> RTCInboundRtpStreamStats?
* pliCount: *"only valid for video and is sent by receiver"* -> RTCInboundRtpStreamStats?
* sliCount: *"only valid for video and is sent by receiver"* -> RTCInboundRtpStreamStats?
* nackCount: *"Count ... packets received by the sender and is sent by receiver"* -> ???
* qpSum: *"sum of the QP values of ... framesDecoded for inbound ... framesEncoded for outbound"* -> RTCInboundRtpStreamStats and RTCOutboundRtpStreamStats?

Except for *nackCount* they're all video stats AFAICT. I can attempt a PR if someone tells me where *nackCount* goes.

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-stats/issues/312#issuecomment-453556583 using your GitHub account
Received on Friday, 11 January 2019 15:36:13 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 4 June 2019 15:32:54 UTC