W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > February 2019

Re: [webrtc-pc] Block replaceTrack on pc.close() like the others, not tc.stop(). (#2107)

From: henbos via GitHub <sysbot+gh@w3.org>
Date: Thu, 21 Feb 2019 14:15:21 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-466014575-1550758519-sysbot+gh@w3.org>
> Only question is whether the `replaceTrack` promise should resolve or be rejected.

I think the PR is correct; the promise should be resolved because the track was in-fact replaced. Transmission of that track is a different operation, and even a successful replaceTrack does not guarantee that the new frames reaches the other endpoint. You could be pedantic and update "have the sender switch seamlessly to transmitting withTrack instead of the sender's existing track" to clarify that transmission only occurs if the link is still open, but I don't think it's necessary.

-- 
GitHub Notification of comment by henbos
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/2107#issuecomment-466014575 using your GitHub account
Received on Thursday, 21 February 2019 14:15:22 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 4 June 2019 15:32:55 UTC