W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > February 2019

Re: [webrtc-pc] "Create an RTP sender" doesn't handle creating from SDP (#2072)

From: Amit Hilbuch via GitHub <sysbot+gh@w3.org>
Date: Tue, 19 Feb 2019 21:15:33 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-465312996-1550610932-sysbot+gh@w3.org>
After PR #2085 was merged, the section now reads:

> 
> If no suitable transceiver is found (transceiver is unset), run the following steps:
> 
> If the description is of type "offer" and contains a request to receive simulcast, use the order of the rid values specified in the simulcast attribute to create an RTCRtpEncodingParameters dictionary for each of the simulcast layers, populating the rid member according to the corresponding rid value, and let sendEncodings be the list containing the created dictionaries. Otherwise, let sendEncodings be an empty list.
> 
> Create an RTCRtpSender, sender, from the media description using sendEncodings.
> 

So the algorithm now explicitly states that you pass along the sendEncodings and explains exactly how to create them from the SDP. This should cover this issue as well.

-- 
GitHub Notification of comment by amithilbuch
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2072#issuecomment-465312996 using your GitHub account
Received on Tuesday, 19 February 2019 21:15:35 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 4 June 2019 15:32:55 UTC