W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > February 2019

[webrtc-stats] Rename nackCount to nacksReceived & nacksSent respectively? (#390)

From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
Date: Wed, 13 Feb 2019 18:52:49 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issues.opened-409950287-1550083968-sysbot+gh@w3.org>
jan-ivar has just created a new issue for https://github.com/w3c/webrtc-stats:

== Rename nackCount to nacksReceived & nacksSent respectively? ==
From @vr000m in https://github.com/w3c/webrtc-stats/pull/384#pullrequestreview-195542744:
> When it was in the base class, the ambigious *Count name made sense because the text described how the counters were updated at the sender and receiver. Now that these metrics are being moved to the appropriate dictionary, we can add the suffix -Sent/-Received qualifier.
> 
> If we are going down this path, I would encourage the -suffix, but that would require retiring the -Count metrics.
> 
> Browsers that have implemented these -Count metrics should also chime in? @henbos @aboba @jan-ivar @youennf

I don't actually think we can afford this at this point due to web compat, but I'm breaking this out as a separate issue, for discussion.

Please view or discuss this issue at https://github.com/w3c/webrtc-stats/issues/390 using your GitHub account
Received on Wednesday, 13 February 2019 18:52:50 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 4 June 2019 15:32:55 UTC