W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > December 2019

Re: [webrtc-pc] new is not valid for SctpTransportState (#2422)

From: Harald Alvestrand via GitHub <sysbot+gh@w3.org>
Date: Wed, 25 Dec 2019 10:41:58 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-568883625-1577270517-sysbot+gh@w3.org>
This algorithm seems to be called in a single place. Should we just remove "if provided, otherwise", and thus say that the argument is not optional?
(When implementing this in webrtc, I actually added a "new" state for my own convenience. I wouldn't mind adding it to the enum either.)

https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/api/sctp_transport_interface.h;l=25

-- 
GitHub Notification of comment by alvestrand
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2422#issuecomment-568883625 using your GitHub account
Received on Wednesday, 25 December 2019 10:42:00 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:35 UTC