W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > October 2018

Re: [webrtc-pc] setParameters: check for number of encodings

From: Harald Alvestrand via GitHub <sysbot+gh@w3.org>
Date: Mon, 29 Oct 2018 08:40:00 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-433828491-1540802399-sysbot+gh@w3.org>
The spec is how we agreed to write it - number of layers can only be changed from the default in AddTransceiver.

What I think you are suggesting (and I think it makes some sense) is to let the [[SendEncodings]] length initially be "undefined", that any subsequent modification with setParameters is allowed to change the [[SendEncodings]] length as long as it is "undefined", and that negotiation (SLD/SRD) sets the length of [[SendEncodings]] to 1 if it isn't otherwise set.

But the example given SHOULD return IllegalModificationError much earlier, because it violates step 5:

If sender's [[LastReturnedParameters]] internal slot is null, return a promise rejected with a newly created InvalidStateError.

-- 
GitHub Notification of comment by alvestrand
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2016#issuecomment-433828491 using your GitHub account
Received on Monday, 29 October 2018 08:40:01 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:07 UTC