W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > October 2018

Re: [mediacapture-record] Not clear if onpause/onresume should not be fired if it is already paused/recording

From: Bumsik Kim via GitHub <sysbot+gh@w3.org>
Date: Tue, 09 Oct 2018 18:20:31 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-428297183-1539109229-sysbot+gh@w3.org>
Allowing only one "paused" event fired makes sense to me too.
> the check for the paused state must be inside the queued task.

I don't know much about implementation detail but I'm wondering if it is trivial/common practice? As mentioned in #123, for now Firefox and Chrome change `state` synchronously, [so preventing multiple "paused" event is as easy as adding a single if statement...for now](https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/mediarecorder/media_recorder.cc?l=278).

Currently Chrome does not fire multiple "paused" event, and Firefox (as my fix to add `onpause`/`onresume` is just accepted by the Firefox devs) fires multiple "paused"/"resume" events. Aside from the state transition being async, if W3C prefers only one "pause" event fired I can submit to patch to Firefox.

-- 
GitHub Notification of comment by kbumsik
Please view or discuss this issue at https://github.com/w3c/mediacapture-record/issues/150#issuecomment-428297183 using your GitHub account
Received on Tuesday, 9 October 2018 18:20:32 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:07 UTC