Re: [webrtc-pc] Require RTCRtpHeaderExtensionParameters members.

I've filed https://github.com/w3c/web-platform-tests/issues/10253.

@alvestrand @aboba @stefhak, it's a very small and non-random sample, but I also came across https://github.com/w3c/webrtc-pc/issues/1734#issuecomment-359023684 back in January. It seems like maybe https://github.com/w3c/webrtc-pc/blob/master/CONTRIBUTING.md#tests isn't quite working as intended, or at least not as I *hoped*. (It's deliberately worded in a pretty noncommital way, so hope seems right.)

Elsewhere, @plehegar and I have speculated about whether it might be useful to have a status check on PRs similar to https://github.com/w3c/ash-nazg, but which would *just* check if tests were mentioned/linked anywhere in a PR, and allow anyone with a GitHub account make a failing status pass by checking a "no tests required" checkbox. Do anyone think that might be useful, or more of a nuisance?

-- 
GitHub Notification of comment by foolip
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/1816#issuecomment-377563525 using your GitHub account

Received on Friday, 30 March 2018 16:29:34 UTC