Re: [webrtc-pc] rename RTCIceCandidate.ip to address?

FWIW, from a docs standpoint, I agree with this proposal to rename `ip` to `address`, for a couple of reasons:

1. As @fippo notes, if anyone implements a scenario in which the address is not an IP address, the name becomes obsolescent.
2. This one sounds frivolous but I'm actually serious: property names as short as `ip` are an oddity in documentation, in that they can be difficult to read and to differentiate, potentially resulting in developers missing details as they read. When possible, I feel that 3 or 4 characters is a practical minimum for property names, with certain exceptions like coordinate axis names in some cases.

GitHub Notification of comment by a2sheppy
Please view or discuss this issue at using your GitHub account

Received on Friday, 22 June 2018 20:04:36 UTC