W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > January 2018

Re: [webrtc-stats] RTCRTPStreamStats should have senderId/receiverId

From: henbos via GitHub <sysbot+gh@w3.org>
Date: Wed, 17 Jan 2018 12:01:50 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-358284145-1516190509-sysbot+gh@w3.org>
> Anyway, to answer your question: it's not a 1:1 mapping, more a 1:M mapping. My current understanding is that each `RTCRTPStreamStats` represents one RTP stream, and one sender/receiver could definitely use multiple RTP streams over its lifetime. In the case of the sender, multiple at once if using simulcast.

Ok, thanks! Then having them as separate objects still makes sense.
There is a `rtpstream -> track` reference, at some point we chose not to have redundant references in both directions, but conceptually there is `track -> rtpstream(s)`.

> What's the difference between `RTCVideoSenderStats` and `RTCLocalVideoStreamTrackStats`? Does it have to do with `replaceTrack`? I'm a little confused about the current state of the stats objects.

`RTCVideoSenderStats` is the stats for the sender during all of its lifetime. Imagine a graph that keeps growing indefinitely over time since the sender was created.
The `RTCLocalVideoStreamTrackStats` represents a subset of the graph, starting from and with the baseline of a track being attached to the sender, which grows until the track is no longer attached in which case `objectDeleted = true`.

There is no need for a separate dictionary for this, since a track attachment is just another baseline of the sender stats and for a different duration of time. It was added when we still had a `boolean detached` member, now that all `RTCStats` dictionary has `objectDeleted` it was removed.

I think removing and renaming some of these dictionaries will make the picture less confusing. In the future, if having "track attachment stats" (subsets of the sender attachment stats with other baselines) proves as unnecessary as we think they are we can deprecate and remove these, and only think in terms of sender/receiver stats.

GitHub Notification of comment by henbos
Please view or discuss this issue at https://github.com/w3c/webrtc-stats/issues/293#issuecomment-358284145 using your GitHub account
Received on Wednesday, 17 January 2018 12:01:54 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:21:58 UTC