W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > January 2018

Re: [webrtc-pc] Possibly racy replaceTrack()

From: stefan hakansson via GitHub <sysbot+gh@w3.org>
Date: Wed, 10 Jan 2018 10:10:29 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-356557034-1515578950-sysbot+gh@w3.org> 
I can agree to that having both sync (add/removeTrack) and async methods (replaceTrack) operating on the same thing is not very clean. However, perhaps we can live with it?
Doing  
```
let promise = sender.replaceTrack(track);
// Will "is negotiation needed" happen before or after removeTrack()?
pc.removeTrack(sender);
```
is not what you should do (adding `await` to the first operation would solve it I guess).

-- 
GitHub Notification of comment by stefhak
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1728#issuecomment-356557034 using your GitHub account
Received on Wednesday, 10 January 2018 10:13:32 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:43 UTC