W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > January 2018

Re: [webrtc-pc] Possibly racy replaceTrack()

From: henbos via GitHub <sysbot+gh@w3.org>
Date: Tue, 09 Jan 2018 19:56:26 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-356395988-1515527786-sysbot+gh@w3.org>
> I don't think the "determine if negotiation is needed" here is intended to take direction into account. 

Does that mean it should be valid to replaceTrack() after removeTrack(sender)? I suppose removeTrack() is just a sync way of doing `replaceTrack(null); direction = null`, nothing irreversible.

If so these tests are wrong to assert that the promise is rejected?
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https.html?l=106

-- 
GitHub Notification of comment by henbos
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1728#issuecomment-356395988 using your GitHub account
Received on Tuesday, 9 January 2018 19:56:28 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:21:58 UTC