W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > February 2018

Re: [webrtc-pc] need to clear [[AssociatedMediaStreams]] in removeTrack?

From: henbos via GitHub <sysbot+gh@w3.org>
Date: Mon, 26 Feb 2018 09:38:34 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-368442493-1519637913-sysbot+gh@w3.org>
I don't think we need to clear [[AssociatedMediaStreams]] slot, rather getLocalStreams() implemented on top of getSenders() should filter out any senders whose transceiver's direction is not sendonly or sendrecv. This is compatible with all the other ways of manipulating senders/transceivers and makes sense for what getLocalStreams() is supposed to do; get streams which are "actively" associated with the PC.

This is better than hunting down places where [[AssociatedMediaStreams]] might otherwise have to be updated. If you pause and resume a transceiver by changing its direction for example, it would be unexpected that the streams have been reset. If we make [[AssociatedMediaStreams]] mutable we would have to introduce a bunch of stream APIs to the sender/transceiver.

Speaking of which, it would be helpful to have it exposed as sender.streams, but readonly as to not increase the complexity of this already complicated model.

-- 
GitHub Notification of comment by henbos
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1756#issuecomment-368442493 using your GitHub account
Received on Monday, 26 February 2018 09:38:47 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:01 UTC