W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > February 2018

Re: [webrtc-pc] Removing 'readonly' from Tranceiver's 'direction'.

From: Philip Jägenstedt via GitHub <sysbot+gh@w3.org>
Date: Tue, 06 Feb 2018 16:16:33 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-363474981-1517933792-sysbot+gh@w3.org>
>From some quick searching, it looks to me like there aren't any tests for setting `direction` on `RTCRtpTransceiver` instances at all, but there is this test:
https://wpt.fyi/webrtc/RTCRtpTransceiver-setDirection.html

But the `setDirection()` method was removed in https://github.com/w3c/webrtc-pc/pull/1647, which is probably also where the change happening in this PR was forgotten.

So test updates to match https://github.com/w3c/webrtc-pc/pull/1647 are needed, and this change is just cleanup following that.

-- 
GitHub Notification of comment by foolip
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/1762#issuecomment-363474981 using your GitHub account
Received on Tuesday, 6 February 2018 16:17:49 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:00 UTC