W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > April 2018

[webrtc-pc] Pull Request: Treat rejected m= sections (port of 0) as having "inactive" direction.

From: Taylor Brandstetter via GitHub <sysbot+gh@w3.org>
Date: Fri, 20 Apr 2018 22:42:04 +0000
To: public-webrtc-logs@w3.org
Message-ID: <pull_request.opened-183185874-1524264123-sysbot+gh@w3.org>
taylor-b has just submitted a new pull request for https://github.com/w3c/webrtc-pc:

== Treat rejected m= sections (port of 0) as having "inactive" direction. ==
Fixes #1812.

This will:

- Cause `currentDirection` to change to `"inactive"`
- Cause the remote track to be removed from its stream(s), if
  applicable.

This seems pretty sensible, as the direction has no relevance for a
rejected m= section. No packets will be sent or received for a rejected
m= section (aka, stopped transceiver), so it's effecitvely `"inactive"`;
it would be odd if a different direction in a rejected m= section
produced different behavior.

This also resolves a problem where remote tracks were possibly never
being removed from their streams, which would happen if you set a remote
description with a rejected m= section with "sendrecv" or "sendonly"
direction.

See https://github.com/w3c/webrtc-pc/pull/1845
Received on Friday, 20 April 2018 22:42:11 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:22:01 UTC