Re: [webrtc-pc] RTCRtpContributingSource & RTCRtpSynchronizationSource -> dictionaries

When this was implemented, Chrome had mocks which emulated receving CSRCs. The tests relying on mocks in Chrome was horrible, and for almost all other cases did not add any value, our tests simply did not test the real thing and maintaining a fake implementation was burdensome. When we finally removed mocking so that WPT and other tests would run with the real thing -- greatly improving our test coverage -- this particular feature lost its test coverage on the JavaScript layer.

I don't see how this is testable on a JavaScript layer without emitting CSRCs. We currently only have tests for the lower layers and some plumbing.

If we want WPT coverage for this maybe we need WebDriver support for pretty low level stuff like packets? Sounds like another case of high-effort low-impact work.

-- 
GitHub Notification of comment by henbos
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/1668#issuecomment-347175719 using your GitHub account

Received on Monday, 27 November 2017 13:04:29 UTC