Re: [webrtc-pc] Make legacy API optional to implement

When we installed counters, the intent was that we would count all the variants of CreateOffer with respect to constraints and callbacks, so that we could compare the proportions - but the buckets were intended to first of all capture whether or not we had the failure callback (it was declared illegal not to have it); I don't think we have a counter for the promise-version vs the callback version. @guidou would know.

All of the counters are within$&l=570 - from looking at the code, RTCPeerConnectionCreateOfferLegacyFailureCallback shold catch all of the callbacks.

GitHub Notification of comment by alvestrand
Please view or discuss this issue at using your GitHub account

Received on Tuesday, 28 March 2017 14:01:38 UTC