W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > March 2017

Re: [webrtc-pc] Make legacy API optional to implement

From: Harald Alvestrand via GitHub <sysbot+gh@w3.org>
Date: Tue, 28 Mar 2017 14:01:31 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-289779356-1490709690-sysbot+gh@w3.org>
When we installed counters, the intent was that we would count all the variants of CreateOffer with respect to constraints and callbacks, so that we could compare the proportions - but the buckets were intended to first of all capture whether or not we had the failure callback (it was declared illegal not to have it); I don't think we have a counter for the promise-version vs the callback version. @guidou would know.

All of the counters are within https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp?type=cs&q=RTCPeerConnectionCreateOffer+package:%5Echromium$&l=570 - from looking at the code, RTCPeerConnectionCreateOfferLegacyFailureCallback shold catch all of the callbacks.


-- 
GitHub Notification of comment by alvestrand
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1086#issuecomment-289779356 using your GitHub account
Received on Tuesday, 28 March 2017 14:01:38 UTC

This archive was generated by hypermail 2.3.1 : Wednesday, 9 October 2019 15:14:52 UTC