W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > March 2017

[webrtc-pc] Pull Request: Changing iceCandidatePoolSize to an octet and adding EnforceRange.

From: Taylor Brandstetter via GitHub <sysbot+gh@w3.org>
Date: Fri, 03 Mar 2017 18:59:29 +0000
To: public-webrtc-logs@w3.org
Message-ID: <pull_request.opened-109034213-1488567568-sysbot+gh@w3.org> 
taylor-b has just submitted a new pull request for 
https://github.com/w3c/webrtc-pc:

== Changing iceCandidatePoolSize to an octet and adding EnforceRange. 
==
Fixes #1048.

Changing it to an octet limits the range to 0-255; there shouldn't be
any situation where an application wants to create thousands of pooled
candidates.

Adding [EnforceRange] means that if the application provides a 
negative
value or one greater than 255, a TypeError is thrown, rather than the
value being converted to the valid range by doing "mod 256".

See https://github.com/w3c/webrtc-pc/pull/1055
Received on Friday, 3 March 2017 18:59:39 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:40 UTC