W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > June 2017

Re: [webrtc-pc] RTCPeerConnection.close: release transceiver before ICE transport

From: Philipp Hancke via GitHub <sysbot+gh@w3.org>
Date: Wed, 21 Jun 2017 08:47:44 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-310010734-1498034862-sysbot+gh@w3.org>
Good catch.

I think this should be done slightly different since currently we repeat a lot of the steps from http://w3c.github.io/webrtc-pc/#dom-rtcrtptransceiver-stop (search for RTCP BYE).
Instead we should
1) run the steps to stop the transceiver
2) close the dtls transport (so a close_notify is sent)
3) close the ice transport

Not from your PR but a few lines below:
> set
>                     <code><var>sender.transport.state</var></code> and
>                     <code><var>sender.transport.transport.state</var></code> to
>                     "closed".

This does not make sense even in the current spec since the ice transport was closed before.

GitHub Notification of comment by fippo
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/1414#issuecomment-310010734 using your GitHub account
Received on Wednesday, 21 June 2017 08:47:50 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:21:40 UTC