W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > June 2017

Re: [webrtc-pc] Remove condition "If channel's underlying data transport is not established yet, then abort these steps" from send()

From: Soares Chen via GitHub <sysbot+gh@w3.org>
Date: Tue, 20 Jun 2017 03:01:29 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-309631317-1497927688-sysbot+gh@w3.org>
My thinking was that the closing procedure does not necessarily get invoked by closed, e.g. when closed by remote peer. In that case the changing from `open` to `closing` could is queued as a task and could result in race condition.

But you are right that the whole step can be removed entirely. Because even if we guard against that, the remote peer can still close while data being sent and result in data loss. It is simpler to just queue it to the buffer regardless and let the closing procedure handle discarding the queue.

Closing this in favor of #1404.

-- 
GitHub Notification of comment by soareschen
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/1398#issuecomment-309631317 using your GitHub account
Received on Tuesday, 20 June 2017 03:01:36 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 4 June 2019 15:32:44 UTC