- From: Bernard Aboba via GitHub <sysbot+gh@w3.org>
- Date: Thu, 15 Jun 2017 14:29:03 +0000
- To: public-webrtc-logs@w3.org
The following commits were just pushed by aboba to https://github.com/w3c/webrtc-pc: * Throw error if data channel's buffer is filled, rather than closing. Fixes #1148. Option 2 for fixing the issue. The application doesn't need to know the buffer's size ahead of time, because filling the buffer is no longer an irrecoverable error. If it doesn't care about latency, an application could send until an exception is thrown, then wait for the "bufferedamountlow" event until it can send again, similar to a non-blocking socket. Note that this is deliberately different than how WebSockets work, because the circumstances are slightly different: with WebSockets, it was expected that applications had code to handle them being closed unexpectedly. But this isn't true of WebRTC DataChannels, because before an SCTP-level timeout can occur, the application would have done an ICE restart and repaired the problem. by Taylor Brandstetter https://github.com/w3c/webrtc-pc/commit/235529a0fdde05116bb9452c9b9c83100dac2d03 * Trying to make RTCDataChannel.send behavior more clear. by Taylor Brandstetter https://github.com/w3c/webrtc-pc/commit/cf37ad14f6c8f0b2ead25b3832143644aeeac1bf * s/no more/not enough by Taylor Brandstetter https://github.com/w3c/webrtc-pc/commit/d56f593e1fd751895a90b3ddbd00ee11494d4c5f * Change InvalidAccessError to TypeError. by Taylor Brandstetter https://github.com/w3c/webrtc-pc/commit/81de077f99b83738f3e1fb12301597c147f38f5b * Merge pull request #1209 from taylor-b/issue_1148_dc_send_exception Throw error if data channel's buffer is filled, rather than closing. by Bernard Aboba https://github.com/w3c/webrtc-pc/commit/51159df99bdf9a4a27852abfbadaf78498d56788
Received on Thursday, 15 June 2017 14:29:10 UTC